Thomas Fuchs comments

Results 65 comments of


                                            Thomas Fuchs

Minification

@mathiasbynens Indeed, one of the main reasons we recommend inlining the library code.

Design Sysops icon

Do you accept PRs?

Credit where credit is due

I smell a lawsuit.

Object.getPrototypeOf in isPlainObject

Fix invalid variable name `key` in commonjs environnement.

I'm not quite sure what this does, why it is a problem, and how to test it. Can you explain in some more detail?

Tagging

Done, tagged current version with `v1.5`.

Method dispatchEvent in chrome pass 'event' by reference.

Hi there! What's the reason for this? Do you want this for jQuery compatibility? What's the problem that you're running into?

Allows shortcuts to be assigned to more than one scope

Hey! This code is leaking globals. Also, before I can accept it, it needs to have tests written (I still need to get around to write basic scope tests). Additionally,...

Support server side rendering

What's the purpose of this? Why would you want to use a library for keyboard shortcuts on the server?

Key Sequences

I like this, but am not sure about the best API for it yet. It might not be the best way to just sequence up shortcuts, and I feel a...