Mattes D
Mattes D
Hello again. Sorry, but this is highly unlikely to happen any time soon (which means a few years at least). There's very few people actually working on Cuberite right now,...
I'm not too happy with the `cFastRandom` replacement. We have no idea how fast the replacement would be, and we want it to be really fast. As for the types,...
There are not many places where the server uses `printf` itself. On the other hand, there's a lot of places that use printf-like syntax - the logging, and various text...
Note: https://github.com/fmtlib/fmt looks promising at first quick glance
If you want something easier for a start, try "Replace "ad hoc Functor classes" with lambdas" - it means removing the `cItemCallback` template and replacing its usage with lambda functions....
This could be related: https://github.com/cuberite/cuberite/blob/7678d5e6ed6fcc9361416ef41c43fa09a1d49f6f/src/ChunkSender.cpp#L281-L284
Most of the violations are either in prehistoric code, or in Lua bindings, where it is somewhat customary to call the lua state parameter `L` (or `tolua_s`, as generated by...
I've added some tidbits of review, it's definitely not complete yet. I'd like you to reconsider how the individual loot tables are loaded. I don't think having a hard-coded list...
I thought: not filenames, but loot table names. So whatever is stored in the NBT / schematic (`cBlockEntityWithItems::m_LootTable`), that it used as the key to the map. Or is that...
We should still think about implementing per-world overrides of the loot tables - vanilla supports that using data packs that have loot table files in a predefined location "override" the...