Madhur Gupta

Results 8 issues of Madhur Gupta

It seems like the CI is failing with the following error. Seems related to #4927 ``` values-ks-arab: Resource and asset merger: Invalid resource directory name ```

ANDROID_NDK_HOME is deprecated and will be removed in the future so we should use the recommended solution for this ``` WARNING: Support for ANDROID_NDK_HOME is deprecated and will be removed...

code-quality

Currently, most of the application is just one big module and it is a good idea to start considering making multiple modules for different features. There is a very good...

code-quality

**Summary:** As per the discussion on the [thread](https://github.com/commons-app/apps-android-commons/pull/3481#issuecomment-597563335) We should replace the ProgressDialog with ProgressBar because it was deprecated in API 26 https://developer.android.com/reference/android/app/ProgressDialog

code-quality

**Summary:** The app on The App Store needs more ratings and reviews, we can add a little popup displayed before the user closes the app which will ask the user...

enhancement
debated

**Hilt** is a dependency injection built on top of Dagger, it is much easier to understand and implement than Dagger. https://developer.android.com/training/dependency-injection/hilt-android **Flows** is a Kotlin extension for coroutines and works...

code-quality
discussion

Great work on the emulator implementation, it would be great if there could be 2 player support.

Hi all, We are brainstorming some ideas for the following year's grant proposal and would love to gather some ideas from everyone, especially the regular users of the app. **Few...

discussion