apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Replace ProgressDialog with ProgressBar

Open madhurgupta10 opened this issue 5 years ago • 3 comments

Summary: As per the discussion on the thread

We should replace the ProgressDialog with ProgressBar because it was deprecated in API 26 https://developer.android.com/reference/android/app/ProgressDialog

madhurgupta10 avatar Mar 11 '20 10:03 madhurgupta10

@nicolas-raoul i want to work on this issue please assign me

Rishavgupta12345 avatar Mar 08 '22 06:03 Rishavgupta12345

@madhurgupta10 @nicolas-raoul I was assigned this issue but I found out that this issue is pretty old.

and this feature is already implemented in our app, we are already using the progress bar in the ZOOM ACTIVITY.

so you can close this issue

Rishavgupta12345 avatar Mar 23 '22 06:03 Rishavgupta12345

@Rishavgupta12345 : Understood, you are always free to unassign yourself from any issue. About closing this issue: I see that many classes are still using android.app.ProgressDialog, for instance fr/free/nrw/commons/upload/UploadActivity.java or fr/free/nrw/commons/auth/LoginActivity.java.

nicolas-raoul avatar Mar 23 '22 08:03 nicolas-raoul