Marc-André Cournoyer
Marc-André Cournoyer
It would be awesome if offenses found in JSON pointed to the exact line number. Current situation: ``` sections/main-collection.liquid:98: suggestion: MatchingSchemaTranslations: settings.center_align_text.label missing translations for cs, da, de, es, fi,...
It was disabled by default in Shopify/theme-check#160 because of issues with optional parameters. Possible there's a better way to make this all work out. But I can't think of any...
At quick glance, there are few things in there we could turn into new checks.
```liquid # bad {% for product in all_products %} {% if product.handle == 'foobar' %} {% assign p = product %} {% endif %} {% endif %} # good {%...
Bad: ``` {% assign article = ... %} {% assign product = ... %} {% assign collection = ... %} ``` etc. All the global objects in https://shopify.dev/docs/themes/liquid/reference/objects We should...
Port https://github.com/Shopify/dawn-internal/pull/532 to a check
When a Fiber is stopped by the scheduler, it raise an `Async::Stop` in the Fiber to stop it. However, the backtrace of this exception will be the place where the...