Marc-André Cournoyer

Results 27 issues of Marc-André Cournoyer

We ignore `UnusuedSnippet` check as soon as a dynamic render is used: `{% render block %}` https://github.com/Shopify/theme-check/blob/master/lib/theme_check/checks/unused_snippet.rb#L20 Maybe this is not needed for `render`? Need to revisit this.

linter

Should run all the translation checks on https://shopify.dev/docs/themes/sections#locales

linter

It was disabled by default in #160 because of issues with optional parameters. Possible there's a better way to make this all work out. But I can't think of any...

enhancement
linter
p:medium
e:3

At quick glance, there are few things in there we could turn into new checks.

linter
p:medium
e:13

It would be awesome if offenses found in JSON pointed to the exact line number. Current situation: ``` sections/main-collection.liquid:98: suggestion: MatchingSchemaTranslations: settings.center_align_text.label missing translations for cs, da, de, es, fi,...

linter

See list of deprecated properties on https://shopify.dev/docs/themes/liquid/reference/objects/deprecated-objects

linter

Translation keys can have Liquid code in them to receive arguments: ``` "page": "Page {{ number }}", ``` We should run a few applicable checks on those (`SpaceInsideBraces`, `SyntaxError`, `UnknownFilter`).

linter
p:low

This is only about translations validate. See #70 for validating the format of the file. Doesn't seem to be documented anywhere, but `settings_schema.json` accepts translations: ```json [ { "name": {...

linter

See https://shopify.dev/docs/themes/settings#file-format-overview for format

linter

See https://shopify.dev/docs/themes/sections#using-section-schema-tags for the accepted structure. However, keep in mind that this page doesn't mention that all values that end up in the UI can be localized. Translation checks in...

linter