Marc-André Cournoyer

Results 27 issues of Marc-André Cournoyer

Port https://github.com/Shopify/dawn-internal/pull/532 to a check

linter

Bad: ``` {% assign article = ... %} {% assign product = ... %} {% assign collection = ... %} ``` etc. All the global objects in https://shopify.dev/docs/themes/liquid/reference/objects We should...

enhancement
linter
p:low
e:2

```liquid # bad {% for product in all_products %} {% if product.handle == 'foobar' %} {% assign p = product %} {% endif %} {% endif %} # good {%...

good first issue
performance

I see you added a link to my GitHub profile at the bottom of the README, thx for that. But please add a link to **the project page** at the...

Fixes the following error when training on two GPUs: > Assertion `THCTensor_(checkGPU)(state, 3, self_, src1, src2)' Solution found here: https://github.com/torch/cutorch/issues/434#issuecomment-237281807

# Issue summary When Captcha support is enabled, browsing to http://127.0.0.1:9292/account/login will sometimes trigger the captcha. Submitting the captcha on http://127.0.0.1:9292/challenge just redirects back to the same page. See https://community.shopify.com/c/online-store-2-0/unable-to-log-into-customer-account-when-using-shopify-theme/m-p/1343096/highlight/false#M1414...

Type: Enhancement
Area: @shopify/theme
open for contributions

### Does your PR solve an issue? Because `ColumnType` and friends are not public, it makes it impossible to implement custom decoding that depend on column type or flags.

This is only about translations validate. See Shopify/theme-check#70 for validating the format of the file. Doesn't seem to be documented anywhere, but `settings_schema.json` accepts translations: ```json [ { "name": {...

enhancement
area:theme-check

Translation keys can have Liquid code in them to receive arguments: ``` "page": "Page {{ number }}", ``` We should run a few applicable checks on those (`SpaceInsideBraces`, `SyntaxError`, `UnknownFilter`).

enhancement
area:theme-check

See list of deprecated properties on https://shopify.dev/docs/api/liquid/objects (search for deprecated)

enhancement
area:theme-check