Marc-André Cournoyer

Results 41 comments of Marc-André Cournoyer

I think this means comments won't be available in the AST anymore right? That might break tools using AST walking to inspect comments. I only know of https://github.com/Shopify/theme-check, but it's...

Oh this is good Darryn! Thanks for the suggestion.

Ideally, this should be fixed in Liquid itself. It should tell us where the error happens. This will not be an easy one 😄

I test w/ a `sleep`, and sending SIGINT to the worker sleeping. Here's what I got: ``` Async::Stop: {cause: #} /Users/ma/.gem/ruby/3.4.4/bundler/gems/async-53670d16cb43/lib/async/scheduler.rb:221:in 'IO::Event::Selector::KQueue#transfer' /Users/ma/.gem/ruby/3.4.4/bundler/gems/async-53670d16cb43/lib/async/scheduler.rb:221:in 'Async::Scheduler#block' /Users/ma/.gem/ruby/3.4.4/bundler/gems/async-53670d16cb43/lib/async/scheduler.rb:254:in 'Async::Scheduler#kernel_sleep' ``` Seems there is...

Oh yeah this is a very good idea @darryn! Please create an issue 😄

The check to upload is https://github.com/Shopify/theme-check/blob/master/lib/theme_check/checks/img_lazy_loading.rb. We should try hard to keep this on the static analysis side, since that's all Theme Check does now. Note that for LOC or...

> Did we consider using something like a magic comment that allows certain variables? Kind of: https://github.com/Shopify/theme-check/pull/134#discussion_r568861008. But excluding snippets was a simpler, safer, short-term solution. I don't understand your...

That make sense to me! However, I'm unclear on the syntax. Is `{% comment %}theme-check variables tags, potatoes{% endcomment %}` the magic comment to define global variables?

I think it'd be more uniform w/ `theme-check-disable` comments if it was: ``` {% comment %}theme-check-variables tags, potatoes{% endcomment %} ``` (Adding the dash)

Since this is a Theme Check concern, I feel it should be a comment. In my mind, there's no reason to change the code just to please Theme Check, it...