Marc-André Cournoyer

Results 26 comments of Marc-André Cournoyer

Ah make sense in this case! Maybe just disallow it a the root instead?

The check to upload is https://github.com/Shopify/theme-check/blob/master/lib/theme_check/checks/img_lazy_loading.rb. We should try hard to keep this on the static analysis side, since that's all Theme Check does now. Note that for LOC or...

👍 Appears to be documented here: https://shopify.dev/docs/themes/liquid/reference/objects/block#block-shopify_attributes. Maybe we could check that as soon as `sections.blocks` is referenced in a template `block.shopify_attributes` is always present.

Hey @chenyukang! Looks interesting. What's the difference between bdwgc and libgc? It seems to be coming from the same project. Is it just a more recent version?

I'm having trouble compiling on Mac OS X. ``` configure.ac:117: error: possibly undefined macro: AC_MSG_ERROR If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:401:...

Yes I got pkg-config and autoconf 2.69 like mentioned here: https://github.com/ivmai/bdwgc/issues/16