Marc-André Cournoyer

Results 26 comments of Marc-André Cournoyer

You mean using the existing autocorrect feature? => https://github.com/Shopify/theme-check/blob/master/lib/theme_check/checks/space_inside_braces.rb#L51 And this feature could be exposed to vscode as a quick action?

Oh yeah this is a very good idea @darryn! Please create an issue 😄

Ideally, this should be fixed in Liquid itself. It should tell us where the error happens. This will not be an easy one 😄

> Did we consider using something like a magic comment that allows certain variables? Kind of: https://github.com/Shopify/theme-check/pull/134#discussion_r568861008. But excluding snippets was a simpler, safer, short-term solution. I don't understand your...

That make sense to me! However, I'm unclear on the syntax. Is `{% comment %}theme-check variables tags, potatoes{% endcomment %}` the magic comment to define global variables?

I think it'd be more uniform w/ `theme-check-disable` comments if it was: ``` {% comment %}theme-check-variables tags, potatoes{% endcomment %} ``` (Adding the dash)

Since this is a Theme Check concern, I feel it should be a comment. In my mind, there's no reason to change the code just to please Theme Check, it...

Ended up being more translations in there than anticipated, details in https://github.com/Shopify/theme-check/pull/68.

The pushing to rubygems has been mostly automated. It does require a manual pumping of the version in the code, then you do have to go to https://shipit.shopify.io/shopify/theme-check/rubygems and click...

Oh this is good Darryn! Thanks for the suggestion.