Samuele Maci

Results 57 comments of Samuele Maci

@Stranger6667 It was an issue that once I've reported to serde-json (I can find the issue eventually) and I was suggesting to allow support for (i|u)128, but the general community...

I was trying to play around the concept of perfect precision via `rug` library. The concept was: * Integer can be represented perfectly if we assume unbounded number of bit...

The branch is currently on https://github.com/macisamuele/jsonschema-rs/tree/maci-perfect-precision It's not into a reviewable state due to the big number of tests commented out (mostly related to error messages) I'll try to re-arrange...

I see your point on "there will be no basic keywords", the aspect that I would highlight in here is that using _composite_ keywords is a way of improving performances...

It might be worth exploring. Combining validator together would help performances but it will be an hit on maintenance cost as well. I would be careful on merging concepts together...

Ideally we should try to reduce as much as possible floating point operations (https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp). At the current stage we rely on floats on few validators (min, max, const and multipleOf),...

@Stranger6667 this approach would make the definition of the keywords more involved and dependent on multiple keywords, still it might provide noticeable improvements. Have you considered the possibility of running...

@Stranger6667 : something that might also be worth to mention is that certain keywords have some intrinsic dependencies on others (ie. `maxItems` is meaningless if `type` is not `array`) and...

I’ll read it carefully in a bit ... but looks very similar to what I eventually had in mind (in order to pay the Value::as_* once and not once per...

thanks for contributing to the project. I'm not sure i understand what is the problem that this PR is trying to address. could you provide a sample output of before...