Mehdi Achour comments

Results 279 comments of


                                            Mehdi Achour

trafficstars

No loader is configured for .glb and .hdr files

@ikarus-akhil you could provide a PR to add support for both files extensions in order to speed up things. Check https://github.com/remix-run/remix/pull/3985 for an example on how to do that.

Full app crash if prop spread is before key inside loop

Seems to have been fixed upstream in esbuild https://github.com/evanw/esbuild/issues/2534 Fix will probably land in esbuild 0.15.8

[ERROR] Could not resolve "pg-native" when making single file build output

@gdonoso94 as you can see, there was a PR that went stale and got closed. The solution is to open a new PR to expose the esbuild `externals`option.

Document the gotcha for esbuild css plugin

Definitely, but until then, the issue should be properly documented for our users. Thank you again for your contribution, already using it! 🙏

feat(remix-react): add `timeout` prop to `LiveReload` component

Hi @joelazar, thank you for your submission (and sorry for the delay!) Can you target `dev` instead of `main` as per our [contributing guide](https://github.com/remix-run/remix/blob/main/docs/pages/contributing.md#making-a-pull-request) requirement?

initial work for document requests

@brophdawg11 is there a decision doc for this work? Would help me follow along

After updating to 1.7.2 from 1.6.8: TypeError: (0 , import_react.useMatches) is not a function

@nkrmr do you mean 1.7.4? Bug was reported on 1.7.2 and the fix haven't been merged yet, see #4301

`FetchError: request to http://0.0.0.0:8000/graphql failed, reason: socket hang up`

@IgnisDa could you provide a reproduction somewhere? Might be a problem with our web-fetch package

Typescript compilation fails

I successfully reproduced the issue with NodeFileOnDisk 👍 However, I'm not sure we will be able to fix errors from Cloudflare pages & workers, as they seem to emanate from...

Server Side Top Level Await does not work

The error message seems quite self-explanatory: top level await are not available for node14. Can you try with node16 or maybe node14.14 (see https://github.com/evanw/esbuild/issues/253#issuecomment-1042859888)?