remix
remix copied to clipboard
initial work for document requests
Closes: #
- [ ] Docs
- [ ] Tests
Testing Strategy:
🦋 Changeset detected
Latest commit: ccae87fbcd74dd68774c1a4952ce37ca32d64454
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
| Name | Type |
|---|---|
| @remix-run/server-runtime | Patch |
| @remix-run/cloudflare | Patch |
| @remix-run/deno | Patch |
| @remix-run/dev | Patch |
| @remix-run/node | Patch |
| @remix-run/react | Patch |
| @remix-run/cloudflare-pages | Patch |
| @remix-run/cloudflare-workers | Patch |
| create-remix | Patch |
| @remix-run/architect | Patch |
| @remix-run/express | Patch |
| @remix-run/netlify | Patch |
| @remix-run/vercel | Patch |
| @remix-run/serve | Patch |
| remix | Patch |
| @remix-run/eslint-config | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Just curious, what's this going to do? Remix already serves document requests for SSR so I suppose is another thing
Just curious, what's this going to do? Remix already serves document requests for SSR so I suppose is another thing
All of the data loading / error handling logic is no longer going to be owned in the server-runtime, but rather by the router package. Essentially this now calls router.query(request) and that's it™️
@brophdawg11 is there a decision doc for this work? Would help me follow along
@machour Yep! https://github.com/remix-run/remix/blob/main/decisions/0007-remix-on-react-router-6-4-0.md - this PR is steps 1.iii/1.iv under Decision - steps 1.i/1.ii were already merged in #4245 and #4359 (behind the compile-time flag)
Need to add a changeset to describe the changes in error/catch boundary behaviors in Remix. Merging this PR will enable those even without the flag enabled.
I think this is good to go now? Let's touch base with @chaance and make sure that we're good to merge this (since he already cut the 1.7.6 release branch). This code in dev, without the feature flag enabled, would just result in the minor fixes to catch/error boundary handling and could be part of a 1.7.7 if needed. But the plan is to enable the feature flag for a 1.8.0-pre.0 later this week or early next week.
🤖 Hello there,
We just published version v0.0.0-nightly-47b5b54-20221116 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
Thanks!