remix icon indicating copy to clipboard operation
remix copied to clipboard

initial work for document requests

Open jacob-ebey opened this issue 3 years ago • 5 comments
trafficstars

Closes: #

  • [ ] Docs
  • [ ] Tests

Testing Strategy:

jacob-ebey avatar Oct 18 '22 22:10 jacob-ebey

🦋 Changeset detected

Latest commit: ccae87fbcd74dd68774c1a4952ce37ca32d64454

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/serve Patch
remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 18 '22 22:10 changeset-bot[bot]

Just curious, what's this going to do? Remix already serves document requests for SSR so I suppose is another thing

sergiodxa avatar Oct 21 '22 14:10 sergiodxa

Just curious, what's this going to do? Remix already serves document requests for SSR so I suppose is another thing

All of the data loading / error handling logic is no longer going to be owned in the server-runtime, but rather by the router package. Essentially this now calls router.query(request) and that's it™️

jacob-ebey avatar Oct 21 '22 22:10 jacob-ebey

@brophdawg11 is there a decision doc for this work? Would help me follow along

machour avatar Nov 01 '22 20:11 machour

@machour Yep! https://github.com/remix-run/remix/blob/main/decisions/0007-remix-on-react-router-6-4-0.md - this PR is steps 1.iii/1.iv under Decision - steps 1.i/1.ii were already merged in #4245 and #4359 (behind the compile-time flag)

brophdawg11 avatar Nov 01 '22 21:11 brophdawg11

Need to add a changeset to describe the changes in error/catch boundary behaviors in Remix. Merging this PR will enable those even without the flag enabled.

brophdawg11 avatar Nov 15 '22 20:11 brophdawg11

I think this is good to go now? Let's touch base with @chaance and make sure that we're good to merge this (since he already cut the 1.7.6 release branch). This code in dev, without the feature flag enabled, would just result in the minor fixes to catch/error boundary handling and could be part of a 1.7.7 if needed. But the plan is to enable the feature flag for a 1.8.0-pre.0 later this week or early next week.

brophdawg11 avatar Nov 15 '22 22:11 brophdawg11

🤖 Hello there,

We just published version v0.0.0-nightly-47b5b54-20221116 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Nov 16 '22 07:11 github-actions[bot]