remix icon indicating copy to clipboard operation
remix copied to clipboard

feat(remix-react): add `timeout` prop to `LiveReload` component

Open joelazar opened this issue 3 years ago • 3 comments

LiveReload component's reconnect attempt was hard coded to 1 sec. However, this breaks the feature if the page which attempts to be loaded has a loader that takes more than 1 sec to load (which communicates with :snail: 3rd-party APIs :cry:). In that case, the LiveReload component gets into an infinity loop.

This change allows the consumer to configure the timeout manually.

Also, you could even argue that the default timeout limit should be increased too.

Closes: #

  • [ ] Docs
  • [x] Tests

joelazar avatar Aug 22 '22 09:08 joelazar

🦋 Changeset detected

Latest commit: c55009947d9ffa66ecd709e34c3f9c8eba9b4f08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 30 '22 07:08 changeset-bot[bot]

Hi @joelazar, thank you for your submission (and sorry for the delay!)

Can you target dev instead of main as per our contributing guide requirement?

machour avatar Sep 02 '22 22:09 machour

Hi @joelazar, thank you for your submission (and sorry for the delay!)

Can you target dev instead of main as per our contributing guide requirement?

Ah, sorry :facepalm: , I've changed the target to dev now.

joelazar avatar Sep 03 '22 09:09 joelazar

Thanks @joelazar for the good work! 🙏

pcattori avatar Jan 23 '23 21:01 pcattori

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jan 24 '23 07:01 github-actions[bot]

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jan 30 '23 23:01 github-actions[bot]