Ayoub Mrini

Results 208 comments of Ayoub Mrini

Yep, all targets based on the golang client should have a "broken" content negotiation implementation, we'll probably need to fix [that](https://github.com/prometheus/common/blob/773d5664eb8d228d2c6ba235b1af12fbf7ee9020/internal/bitbucket.org/ww/goautoneg/autoneg.go#L84) or move to another library: https://github.com/elnormous/contenttype seems to better...

> I see a lot of new ways for panic to happen and I did not see a recover. Please can you explain how this is safe. The panic should...

> Thanks; can you add that explanation on the panic call in the new code please? Done, tell me if that's ok.

> Actually when I noted "a lot of new ways for panic to happen" I was looking at `d.mustNewSharedInformer`. I'd added some comments to the fct's body, should move them...

With `2.51.1`, I didn’t find it that difficult to copy labels on multiple browsers. Which versions are you using, on which browser? Could you give more details? Maybe a video...

Actually, the [TestDocumentation](https://github.com/prometheus/prometheus/actions/runs/8866145272/job/24343217892?pr=13965#step:6:346) test is failing. Did you run `make cli-documentation`?

For the failing DCO job: Thanks for your PR. For legal reasons, we require that all commits are signed with a [DCO](https://developercertificate.org/) before we can merge them. See [this blog...

Thanks for reporting this. `/flags` returns the flags the user has set and the defaults as known to `kingpin` (the flags parser we use) https://github.com/prometheus/prometheus/blob/76b0318ed52e655e96a3a4734e3678bf55801616/cmd/prometheus/main.go#L806-L813 For `--storage.tsdb.retention.time`, the default value...