prometheus icon indicating copy to clipboard operation
prometheus copied to clipboard

when changing value for --rules.max-concurrent-evals, –query.max-concurrency this is also need to be change.

Open kushalShukla-web opened this issue 1 year ago • 6 comments

kushalShukla-web avatar Apr 21 '24 09:04 kushalShukla-web

fixes https://github.com/prometheus/prometheus/issues/13931

kushalShukla-web avatar Apr 21 '24 09:04 kushalShukla-web

Screenshot from 2024-04-28 06-02-49

kushalShukla-web avatar Apr 28 '24 10:04 kushalShukla-web

hey @machine424 i think its failing because of some error in tsdb part . can we still merge this PR ?

kushalShukla-web avatar Apr 28 '24 10:04 kushalShukla-web

Actually, the TestDocumentation test is failing. Did you run make cli-documentation?

machine424 avatar Apr 29 '24 13:04 machine424

Could you also make sure your PR description is correctly linked with the related issue?

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

ArthurSens avatar Apr 29 '24 18:04 ArthurSens

sure i will do it .

kushalShukla-web avatar May 04 '24 05:05 kushalShukla-web

Oh man I was so busy with exams , I will do this

kushalShukla-web avatar May 13 '24 10:05 kushalShukla-web

i dont know why these changes also get pushed , i stash these changes but still got pushed . will create a new pr .

kushalShukla-web avatar May 18 '24 10:05 kushalShukla-web