Munir Abdinur

Results 35 comments of Munir Abdinur

> @mabdinur I've tried to add changelog and merge from 1.x but I don't have permission to push to this repository. What should I do now? Sorry I should've proposed...

Hey @hamza878, Thanks for bringing this to our attention. The APM Python team is always looking to support new libraries. We'll add this feature request to our backlog. Feel free...

Hi @robinovitch61 @JordanP , Our pycopg instrumentation appends database queries to Span.resource attribute. For long queries this can significantly increase the size of a Span. This is an issue we...

With the addition of the new package this test is failing: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/20247/workflows/9b33a31b-e2e2-4c9b-9e27-ddeec7800120/jobs/1371051. We'll need to update this case to handle/reformat `pkgutil_resolve_name` Something like this could work. Or we could just...

Blocked by: https://github.com/DataDog/dd-trace-py/pull/3907

We can clean up the flask middleware code in a follow up change. Here's what I had in mind: 520d5beb9beb7390028e82b5eb7e1120fc10f44f. I would like to minimize the changes in this PR

failing flask snapshots: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/20152/workflows/0e7c9f4e-80cb-4f3a-ab5c-1ea63afa7d8f/jobs/1364413. Tests spot failing after this [commit](https://github.com/DataDog/dd-trace-py/commit/95d705c0476f5ab86ccb7a64a4599b581fdbc438): https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/20153/workflows/6eda8ea9-ea46-4d52-bc6e-6a89c49eaacd/jobs/1364513

Hey @umutkacar, Thanks for flagging this issue. I just opened a PR to fix this issue.

@ZStriker19 Are we planning to move forward with this change? Should we close this PR?