dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(sampling): change sampling rule to use glob matching for resource

Open ZStriker19 opened this issue 1 year ago • 1 comments

Checklist

  • [x] Change(s) are motivated and described in the PR description.
  • [x] Testing strategy is described if automated tests are not included in the PR.
  • [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • [x] Change is maintainable (easy to change, telemetry, documentation).
  • [x] Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • [x] Documentation is included (in-code, generated user docs, public corp docs).
  • [x] Backport labels are set (if applicable)

Reviewer Checklist

  • [x] Title is accurate.
  • [x] No unnecessary changes are introduced.
  • [x] Avoids breaking API changes unless absolutely necessary.
  • [x] Testing strategy adequately addresses listed risk(s).
  • [x] Change is maintainable (easy to change, telemetry, documentation).
  • [x] Release note makes sense to a user of the library.
  • [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • [x] Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • [x] This PR doesn't touch any of that.

ZStriker19 avatar Sep 08 '23 20:09 ZStriker19

Benchmarks

Benchmark execution time: 2023-10-24 15:42:51

Comparing candidate commit df3fd80ed60606bb34e6bd5322504aa05755b1d3 in PR branch zachg/add_glob_matching_for_resource with baseline commit 5b18d1696794048939ad8a3253dc5d18a1271720 in branch 2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 0 unstable metrics.

pr-commenter[bot] avatar Sep 08 '23 21:09 pr-commenter[bot]

@ZStriker19 Are we planning to move forward with this change? Should we close this PR?

mabdinur avatar Apr 25 '24 09:04 mabdinur