Rome Reginelli
Rome Reginelli
After you submit a CheckCreate transaction, you need the ID of the resulting Check ledger object in order to cash or cancel it. However, getting a Check ID is currently...
It would be handy to have a utility function that checks whether the `Domain` associated with an account object is is [verified using an xrp-ledger.toml file](https://xrpl.org/xrp-ledger-toml.html#account-verification). The actual code to...
There are a lot of different ways of doing transaction signing and submission, but we've learned from experience what models work better than others, and the way I most recommend...
The request models to sign a transaction using a rippled server are unnecessary and can be used unsafely. To reduce confusion, we should remove them. The [`rippled` sign method](https://xrpl.org/sign.html) is...
The [Secret Numbers standard (XLS-12)](https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-12) defines an alternate format for an account seed or private key, which is used by XUMM wallet and possibly others. The Wallet class should support...
Both xrpl.js and xrpl-py have two ways of instantiating their `Wallet` class: - from an existing seed - generating a new random seed In both cases, one of these options...
The [`getBalanceChanges()` method of xrpl.js](https://js.xrpl.org/modules.html#getBalanceChanges) makes it much easier for beginners to reliably get information about how a transaction affected their balances of XRP and tokens. Doing it "by hand"...
We should have models for ledger data, including the [ledger header](https://xrpl.org/ledger-header.html) and all [types of ledger objects](https://xrpl.org/ledger-object-types.html) that can be in the ledger's state data. This would aid reading/exploring and...
The way xrpl.js lets you do requests and event handlers with the WebSocket client is pretty handy. It would be nice if xrpl-py's sync WebSocket client supported something similar, with...
The names of the signing functions are too long. In particular, this example of normal usage is 90 characters long, which is longer than most coding style guides will allow...