Rome Reginelli

Results 168 issues of Rome Reginelli

## Issue Description In most cases, the ledger entry ID of an object in the ledger can be (re-)derived from the protocol & the fields of the object as stored....

Food for Thought
Amendment

## Issue Description The [feature](https://xrpl.org/feature.html) command inaccurately reports a status of `"vetoed": true` for amendments that have had their pre-amendment code retired. ## Steps to Reproduce Call the `feature` method...

API Change
Bug

## Issue Description The [fee command](https://xrpl.org/fee.html) returns a `drops.median_fee` field that is supposed to represent the median transaction cost paid in the last validated ledger. However, due to the way...

API Change

I can't start a stand-alone mode server with the CheckCashMakesTrustLine amendment pre-enabled anymore. (I'm _not_ talking about force-enabling via the `[features]` stanza: I mean controlling which amendments are "officially" enabled...

Bug

The [fix1578 amendment](https://xrpl.org/known-amendments.html#fix1578) changed OfferCreate transactions so that if they used `tfFillorKill` and the transaction was killed, it used the code `tecKILLED` rather than `tesSUCCESS`. We should do the same...

Feature Request
Amendment

## Summary Would it be possible to eliminate the custom number format the XRPL uses to represent issued tokens, and migrate to strictly integer math? I think it could be...

Food for Thought
Testable

## Issue Description The [noripple_check method](https://xrpl.org/websocket-api-tool.html#noripple_check) response contains suggested transactions to fix No Ripple Flag settings, but these transactions inappropriately use `"Fee": 10` rather than `"Fee": "10"`. ## Steps to...

API Change
Bug

The JSON format for ledger objects (as returned by the [`ledger` method](https://xrpl.org/ledger.html) among others) could probably stand to be better-unified [a la transactions](https://github.com/ripple/rippled/issues/2599) but for starters, we could at least...

API Change
Tech Debt

### Signing fails (Serialized transaction does not match original txJSON) when decimal amount contains trailing zeroes When attempting to sign a transaction with an issued currency amount including insignificant trailing...

bug

xrpl.js has [`setTransactionFlagsToNumber()`](https://js.xrpl.org/modules.html#setTransactionFlagsToNumber) to convert flags _from_ a map of names to an integer, and [`parseAccountRootFlags()`](https://js.xrpl.org/modules.html#parseAccountRootFlags) for going from an AccountRoot object's flags integer to a map of booleans, but...

enhancement
good first issue