Marcin
Marcin
> Please add a test On it!
Hey @gogonzo I added a test in `init` for the case with incomplete `datanames` but with `transformers` passed in `modules`. I also edited the text for the existing test that...
I also see a test in `test-module_teal.R` that uses `teal_modules-module_1-validate_datanames-shiny_warnings`. The test starts with `testthat::it("throws warning when dataname is not available"`. I think we could add a test in there...
Yeah, but we also modified `module_teal_data` https://github.com/insightsengineering/teal/pull/1319/files#diff-8f20f15c7749d517fd977941dfda6eaa293268f76f57eb733bf4971273ea4e68R165 so the `shiny_warnings` is restricted with the extended condition. That's why I though an extra test https://github.com/insightsengineering/teal/pull/1319/commits/d2a658fa74f2286ec813bd7d1936987aa1cc4832 in there could be helpful
Yes @gogonzo - it's already included https://github.com/insightsengineering/teal/commit/d2a658fa74f2286ec813bd7d1936987aa1cc4832 in `test-module_teal.R`
@gogonzo maybe there is a missunderstanding in what I thought we wanted to achieve with this issue. If any transformers are passed, then insufficient data warning will not be shown....
Make sense @gogonzo and thank you for the clarification. Will be able to edit the PR today
Sorry for the initial extension of what we planned. Initially I provided restriction to init and to the UI of the module. I just removed the restriciton from the UI....
Thanks for the patience @gogonzo - just checked with 2 apps and run tests locally. This now only displays the warning in UI and hides the warning for the console...
I see 58 issues in tests on local when I run tests for below dependencies. Those are the same as appear in GitHub Actions ```r devtools::test_file('tests/testthat/test-module_teal.R') ``` ```r > packageVersion('teal.slice')...