Marcin

Results 135 comments of Marcin

hit this in 2024

I can understand the need for global transformations to be allowed, so that you - don't need to apply the same transformation to all modules if you want it to...

I like the idea @kartikeyakirar proposed with mapping and reusing the mechanism for filtering. The biggest pro is that it is known and we have solid foundations to be reused....

Spent some time today reviewing https://github.com/insightsengineering/teal/pull/1209 and I found this approach a lot easier and handier than what we've seen so far. Just a quick reply. Will come up with...

As I wrote in here https://github.com/insightsengineering/teal/pull/1209#issuecomment-2100147645, with this PR we are very flexible and can allow the whole module to be changed/transformed - not only the data

hey guys, just curious about the state of this PR as it blocks this https://github.com/insightsengineering/teal.modules.hermes/pull/375

> Do we want to add library calls for all packages that are attached at the end of the module or all packages that are loaded? I would go with...

Ok, so it's either a decision if we just leave a warning that some packages are missing, or we allow them to be installed, but in both cases we do...

On the main topic I don't see a reason why we do not allow to specify libraries in `teal_data() |> within()` block, as sometimes data processing requires extra packages. And...

Alrighty, so what's left in here to decide (and potentially implement)? - :white_check_mark: we allow a user to specify libraries in `within` on the preprocessing - :white_check_mark: teal appends libraries...