teal
teal copied to clipboard
insightsengineering
updated TealAppDriver method for adding , removing and setting filter for `MAE` objects
fixes https://github.com/insightsengineering/teal/issues/1189
- [x] Adding filter
- [x] Setting filter
- [x] removing filter
Code Coverage Summary
Filename Stmts Miss Cover Missing
------------------------------ ------- ------ ------- --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R 36 25 30.56% 21-37, 40-47
R/get_rcode_utils.R 31 1 96.77% 50
R/include_css_js.R 22 17 22.73% 12-38, 76-82
R/init.R 86 31 63.95% 108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R 25 25 0.00% 61-87
R/module_bookmark_manager.R 158 125 20.89% 42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R 84 19 77.38% 38-42, 157, 162-175
R/module_nested_tabs.R 161 60 62.73% 39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R 241 178 26.14% 95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R 76 33 56.58% 33-68, 100, 116
R/module_teal_with_splash.R 114 34 70.18% 60-95, 110, 131, 197-198
R/module_teal.R 110 76 30.91% 52-119, 150-151, 157, 168, 181-212
R/module_wunder_bar.R 60 39 35.00% 23-41, 55-64, 68-77
R/modules.R 159 26 83.65% 127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R 19 2 89.47% 30, 34
R/show_rcode_modal.R 19 19 0.00% 17-36
R/tdata.R 53 1 98.11% 154
R/teal_data_module-eval_code.R 27 0 100.00%
R/teal_data_module-within.R 7 0 100.00%
R/teal_data_module.R 6 0 100.00%
R/teal_reporter.R 62 5 91.94% 69, 118-119, 122, 139
R/teal_slices-store.R 29 0 100.00%
R/teal_slices.R 59 12 79.66% 137-150
R/TealAppDriver.R 363 363 0.00% 43-679
R/utils.R 173 1 99.42% 255
R/validate_inputs.R 32 0 100.00%
R/validations.R 58 37 36.21% 110-377
R/zzz.R 12 8 33.33% 3-15
TOTAL 2282 1137 50.18%
Diff against main
Filename Stmts Miss Cover
----------------- ------- ------ --------
R/TealAppDriver.R +92 +92 +100.00%
TOTAL +92 +92 -2.11%
Results for commit: dcd099502314dbd3dbb429bcbfaae63d890f4aee
Minimum allowed coverage is 80%
:recycle: This comment has been updated with latest results
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unit Tests Summary
1 files 30 suites 2m 49s :stopwatch: 240 tests 240 :white_check_mark: 0 :zzz: 0 :x: 505 runs 505 :white_check_mark: 0 :zzz: 0 :x:
Results for commit dcd09950.
:recycle: This comment has been updated with latest results.
Unit Test Performance Difference
| Test Suite | $Status$ | Time on main |
$±Time$ | $±Tests$ | $±Skipped$ | $±Failures$ | $±Errors$ |
|---|---|---|---|---|---|---|---|
| shinytest2-filter_panel | 💔 | $17.44$ | $+3.44$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-init | 💔 | $10.45$ | $+2.26$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-landing_popup | 💔 | $18.59$ | $+3.85$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-module_bookmark_manager | 💔 | $22.75$ | $+5.69$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-modules | 💔 | $17.23$ | $+3.05$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-reporter | 💔 | $32.66$ | $+2.25$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-teal_data_module | 💔 | $10.88$ | $+2.03$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-teal_slices | 💔 | $13.52$ | $+2.52$ | $0$ | $0$ | $0$ | $0$ |
| shinytest2-wunder_bar | 💔 | $8.54$ | $+1.42$ | $0$ | $0$ | $0$ | $0$ |
| tdata | 💔 | $5.24$ | $+1.84$ | $0$ | $0$ | $0$ | $0$ |
Additional test case details
| Test Suite | $Status$ | Time on main |
$±Time$ | Test Case |
|---|---|---|---|---|
| shinytest2-filter_panel | 💔 | $6.03$ | $+1.31$ | e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules |
| shinytest2-filter_panel | 💔 | $6.01$ | $+1.12$ | e2e_filtering_a_module_specific_filter_is_refected_in_other_shared_module |
| shinytest2-filter_panel | 💔 | $5.39$ | $+1.00$ | e2e_module_content_is_updated_when_a_data_is_filtered_in_filter_panel |
| shinytest2-module_bookmark_manager | 💔 | $5.47$ | $+1.52$ | bookmark_manager_button_is_not_rendered_by_default |
| shinytest2-module_bookmark_manager | 💔 | $5.48$ | $+1.97$ | bookmark_manager_button_is_not_rendered_when_enableBookmarking_url_ |
| shinytest2-module_bookmark_manager | 💔 | $5.55$ | $+1.30$ | bookmark_manager_button_is_rendered_when_enableBookmarking_server_ |
| shinytest2-teal_slices | 💔 | $5.96$ | $+1.19$ | e2e_teal_slices_filters_are_initialized_when_global_filters_are_created |
| shinytest2-teal_slices | 💔 | $7.56$ | $+1.33$ | e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created |
| tdata | 💔 | $4.90$ | $+1.82$ | new_tdata_accepts_reactive_and_not_reactive_MAE_and_data.frames |
Results for commit 88cf937021607d5a1d0e4fe4655832705ec6cd96
♻️ This comment has been updated with latest results.
hey guys, just curious about the state of this PR as it blocks this https://github.com/insightsengineering/teal.modules.hermes/pull/375
@marcin, I've kept this PR as a placeholder for now. till the new PR on teal.slice to test the filters for ADaM and MAE data.
TODO:
- [ ] Remove the methods for adding, removing, and setting filters in tealAppDriver.
- [ ] Add tests for filters in the teal_slices package.
This isn't exactly blocking the teal.module.heremrs and teal.module.hleios shinytest2 conversations, but I marked it as blocked due to some ongoing discussions at that time.
As per our conclusion, we will not be testing filters on modules. Once we remove the methods mentioned above, we will also remove the related tests using filtering functionalities.