m26singhvi

Results 10 comments of m26singhvi

Great, thanks for the confirmation. Sure, I will raise a pull request to update the description.

I am not sure how useful option 2 is. Option 1 can help figure out the unique number of SAK distributed and received.

Thanks for taking a look at this. I will soon submit a pull request for this.

@dplore - As captured in https://github.com/openconfig/public/issues/733, this was done to primarily support Macsec model. Changing it back to uint64 would mean that Macsec model will need it's own keychain model,...

Question - Can you provide some insight on why the key needs to be a mac address? Answer - Sorry but I don't think I mentioned that it needs to...

Sounds like this is the only feasible solution to prevent any such future usages. Please note that the latest macsec model doesn't have any hex-string usage, so the scope is...

@dplore - Can we get the fix for #1014 merged ? Also, there will still some ambiguity if the value is just two digits, right ? For e.g. 12 ?

There is a CRYPTO_NONE option available https://github.com/openconfig/public/blob/master/release/models/keychain/openconfig-keychain-types.yang which I think can be used to the crypto-algorithm value to signify unencrypted key.

As per the following snippet from the key chain model, crypto-algorithm is associated with the key and not with the protocol. ``` leaf crypto-algorithm { type identityref { base oc-keychain-types:CRYPTO_TYPE;...

Sure, thanks @rgarunkumar. I raised a separate issue - https://github.com/openconfig/public/issues/785 to understand better about this.