public icon indicating copy to clipboard operation
public copied to clipboard

Update oc-macsec model to use oc-keychain model

Open m26singhvi opened this issue 2 years ago • 2 comments

Currently, openconfig macsec model - public/release/models/macsec/openconfig-macsec.yang has a keychain container for configuring keys.

Recently, a keychain model was published here - https://github.com/openconfig/public/blob/master/release/models/keychain/openconfig-keychain.yang

which allows configuration of keys as well - most of it is pretty similar to what is present in Macsec model already.

It will be good if the macsec model can remove out the key-chain container and refer to the key-chain model defined globally.

m26singhvi avatar Mar 22 '22 11:03 m26singhvi

Thanks for the comment! To help speed this along, I encourage you to submit a pull request to make the changes you would like to see. Thank you!

dplore avatar Mar 29 '22 02:03 dplore

Thanks for taking a look at this. I will soon submit a pull request for this.

m26singhvi avatar Mar 31 '22 12:03 m26singhvi

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

github-actions[bot] avatar May 20 '24 02:05 github-actions[bot]