opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

The logging signal doesn't have a default log emitter provider

Open codeboten opened this issue 3 years ago • 3 comments

As identified during the work for #2354, the log emitter provider doesn't have a default or noop implementation.

codeboten avatar Jan 08 '22 00:01 codeboten

Does this apply to the logging? Unlike metrics and traces, logging doesn't have an API. In case tracing/metrics user adds new instrumentation code and may need the no-op. With logging SDK, we are only taking the whatever the logs emitted and exporting them to backend. If they don't want that then they can simply remove the OTLPHandler.

srikanthccv avatar Jan 08 '22 09:01 srikanthccv

@codeboten Wdyt?

lzchen avatar Mar 14 '22 19:03 lzchen

In my opinion, the NoOpX classes are the API implementation of the API, if there is no API, then there should not be any need for NoOpLogEmitter.

ocelotl avatar Mar 17 '22 20:03 ocelotl

This is implemented by @lzchen here https://github.com/open-telemetry/opentelemetry-python/pull/3038

srikanthccv avatar Jan 06 '23 16:01 srikanthccv