Carine Morel
Carine Morel
> the "no server launch" part clearly indicates that an error was caught, but the message must have been lost somewhere. What was the exit code of the process? 2
I have found an similar issue when there is no given solution function in solution.ml for a graded function. An error is obviously raised internally but nothing is written when...
My mistake, the documentation is wrong (there is a correct version for `require_syntax` and not for `require_expr` and `require`). I just opened a pull request with a correction.
I don't think the function is wrong, I think it is just that it does not what you expect it to do. However, the name may not be very appropriate,...
Thanks for the PR ! All the optimizations (except maybe the ones mentioned in my previous message :p) are great and thanks again for making the git history so readable....
I should have added that the optimization with the cashes is very cool !!
The changes proposed in this PR have already been merged in two different PRs (#133 and #135) that separate "safe" and "unsafe" optimizations. Thanks @polytypic for all this work!
@polytypic I pushed my solution to make the counter work. If you could have a look, that would be great :)
I converted this to a draft PR as a lot of work is still due, in particular because the code of #65 is copied/pasted and adapted for a priority queue.
Nice work, thanks ! Here is a few idea that could make good use of your prints : - make domains push or pop different values or write their own...