Carine Morel

Sorry for the delayed response! We aim to maintain a consistent convention across all Saturn data structures. In the standard library, hash table functions always take the hash table as...

@polytypic: The dscheck tests of the unsafe version result in a segmentation fault. I encountered the same issue with PR #122 after rebasing on main and adding the few necessary...

@polytypic : this PR is ready for review. Could you have a look ?

About the missing safe optimizations: I added the fast path in the push function. However, the benchmarks suggest that adding backoff (either for in `fix_tail` or `find_tail_and_end`) does not improve...

Here some quick comments on the documentation of the Trigger module. The text is clear, with a lot of useful recommendations. - [line 256: ](https://github.com/ocaml-multicore/picos/blob/7eac8be13bce4bce0841b54964ac3612d3f0f777/lib/picos/picos.mli#L256) the `and` and the end...

Thanks ! About the `Computation` module: this is also a very understandable module. I like the way it is sorted (by "Interface for..."). - [`type packed`](https://github.com/ocaml-multicore/picos/blob/f79755a0fe40e29678f007648cd9aab662a35ffa/lib/picos/picos.mli#L633) : this is used...

Fiber module : - [mismatched documentation](https://github.com/ocaml-multicore/picos/blob/f79755a0fe40e29678f007648cd9aab662a35ffa/lib/picos/picos.mli#L999) : the function documented is `create` and the doc is about `new_key`. - [`set_computation`](https://github.com/ocaml-multicore/picos/blob/f79755a0fe40e29678f007648cd9aab662a35ffa/lib/picos/picos.mli#L1090) : what happens if the fiber already has an associated...

Thanks for reporting this ! I will have a look.

I made a list of things that needed fixes [here ](https://github.com/mirage/irmin/pull/2149#pullrequestreview-3029765907). This is clearly outdated, but it's likely that not everything has been done. A lot of it is small...