Luke Warlow

Results 589 comments of Luke Warlow
trafficstars

Happy to bikeshed etc but my proposal would be a new `modal` attribute. It wouldn't change anything by default it just acts as an indicator when used alongside the open...

Adding to agenda as it might help simplify the invokers work that's ongoing. (Would obviously need WHATWG buy in too)

> Could not work? It would potentially for the open as modal on page load. Potentially as I'm not sure on changing boolean attribute to take values. I guess it...

Naming things is hard, could that be another reason to use a new attribute for the modality instead. Then we get potential invoker benefits *and* we don't have to think...

> Could not work? Coming back to this since my original reason against this no longer holds (invoker commands aren't ambiguous anymore). I think this could be a neat way...

Something I've thought of with the menu case is how often do *users* actually like the open on hover? It might be that they should just be an invoker? The...

See https://github.com/openui/open-ui/issues/838 for a potential use case

> in this context a "label" is not a . If like checkbox we want to include the real label in the anatomy too I think it'll be extra important

I guess if we agree it should be changed that begs the follow up question of what to call it 😅 I guess part of this might be answered by...

The repeat button in youtube music seems like a perfect example of this. It has 3 states Repeat Off, Repeat One and Repeat All ![image](https://github.com/openui/open-ui/assets/32498324/497faa7c-564d-4535-b57d-2ad7f2c1d6c5) ![image](https://github.com/openui/open-ui/assets/32498324/c9eac2f4-2728-4c17-8e38-857bbc7792eb) ![image](https://github.com/openui/open-ui/assets/32498324/2d2e4113-660d-441b-99bc-f05f37138248)