[file] Is label the correct name for the file name part of file component

[lukewarlow]

trafficstars

Open UI currently has file-selector-button (which after #913 will be correctly labelled as a button) but it also has a label part. However, this isn't a true label it's more a supplementary piece of text that shows stuff such as file names. As opposed to the checkbox component where its label part is representative of an actual label.

Should we rename this label part?

[scottaohara]

i vote yes, unless it's understood that in this context a "label" is not a <label>.

[lukewarlow]

in this context a "label" is not a .

If like checkbox we want to include the real label in the anatomy too I think it'll be extra important

[lukewarlow]

I guess if we agree it should be changed that begs the follow up question of what to call it 😅

I guess part of this might be answered by what's the semantically correct thing here, accessibility wise? Like is this aria description? Or is this something else?

[css-meeting-bot]

The Open UI Community Group just discussed [file] Is label the correct name for the file name part of file component, and agreed to the following:

• RESOLVED: Rename label part, bikeshed within issue.

The full IRC log of that discussion

<jarhar> Luke: ive been doing cleanup around openui pages. the file structure originally was just using divs, but now its buttons and labels
<gregwhitworth> q+
<jarhar> Luke: i changed label to be a label element, but then got pointed out thats not actually a label. the label is just text, not an accessible name youd get from a label. should we rename that part?
<masonf> q+
<jarhar> Luke: resolution should be that we should rename it, then we can bikeshed
<jarhar> Luke: i think its worth changing because its going to be confusing
<jarhar> gregwhitworth: i made this initial anatomy when openui started, but yeah label should probably be
<jarhar> gregwhitworth: this anatomy should be reworked. the name itself should be selected option or selected options or selected file
<jarhar> gregwhitworth: there are scenarios where people select from within their own world
<jarhar> gregwhitworth: to your point, i like that you proposed two resolutions - yes we should change it. label lets take it back to the same issue to figure out what it should be
<jarhar> gregwhitworth: it needs more work than just that
<Luke> Proposed Resolution: Rename label part, bikeshed within issue.
<jarhar> gregwhitworth: its usually not just a label
<gregwhitworth> q?
<gregwhitworth> ack gregwhitworth
<gregwhitworth> ack masonf
<jarhar> masonf: yeah it shouldnt be label, its the filename
<jarhar> masonf: its the in-page part of the control, it has some representation of the filename
<jarhar> gregwhitworth: yeah, i think the thing is pretty clear
<jarhar> gregwhitworth: it was just the user agents, all of them were not interoperable at all
<masonf> +q
<masonf> +1
<masonf> q-
<Luke> RESOLVED: Rename label part, bikeshed within issue.

[github-actions[bot]]

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

[github-actions[bot]]

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.