Luke Warlow

Results 598 comments of Luke Warlow
trafficstars

Closing this as these integrations will all be upstreamed.

This change matches WebKit and Chromium so I've gone ahead and merged it.

@otherdaniel I'd be curious if you knew what the reasoning for that test being commented out is? Is it possible the xlink namespacing is no longer relevant?

It would be clearer but unfortunately that ship sailed about 4 years ago...

That one engine gives you something like 75% market share though and it's a fairly core part of the API. Now it's possible that doesn't translate to much usage (ultimately...

I'll reopen it. The spec at least says something about the null value now but yeah we need to go through and deal with bits like this and others more...

Based on https://github.com/tc39/ecma262/pull/3222#issue-1995891558 comments in here about ShadowRealms it seems that it will make use of the host callout so is probably handled by the changes to that automatically but...

Yeah TT is exposed to workers so the spec would handle non window envs so no strong reason not to expose to shadow realm in future.