Luke Warlow

Results 598 comments of Luke Warlow
trafficstars

Just a thought this would also potentially serve as a (partial) feature detection (https://github.com/keithamus/invoker-buttons-proposal/issues/24). If an invalid value that doesn't match the defined custom syntax is used for action then...

The one compat issue this wouldn't necessarily solve is "auto" custom actions. Currently there's the ability to do custom auto actions https://open-ui.org/components/invokers.explainer/#custom-behaviour This issue wouldn't fix the issue where the...

Based on that discussion I'm thinking we should heavily encourage requiring a hyphen in custom actions. I also think we shouldn't allow auto values for custom actions. One idea is...

Where would that idl reside on the invoker element or the event? Could you explain a bit more how that would solve the compat issue please. Just so I'm sure...

That's probably a good idea regardless of this issue. But I'm not sure if that helps with future compat concerns? If we add a new action that conflicts with an...

Adding back to agenda to try and move forward discussion on this

> As for enforcement. If we didn't dispatch the event when they break these rules, we'd break polyfills. So the actual enforcement is a tricky one. But if we console...

Going to go ahead and close this, as we got our resolution and the neccessry edits have been mde.

Not a blocker here but we should add label elements to each of the selectlists

@mfreed7 or @gregwhitworth would be good if one of you could approve so we can merge :)