Luke Warlow

Results 596 comments of Luke Warlow
trafficstars

![Screenshot_20231116-090439.png](https://github.com/openui/open-ui/assets/32498324/b4e33479-a41f-497f-9dc2-7fa023c79150) Interestingly Android has a similar cancel Vs close situation but they do allow a cancel function for cancel buttons

https://github.com/openui/open-ui/discussions/950#discussioncomment-7593669 - this discussion suggests that our assumption of a UA only cancel event isn't necessarily correct.

Semi related to this I've raised https://github.com/whatwg/html/issues/10164 - to discuss adding a new `requestClose()` (name tbd) function to dialogs, if this is added we should update the 'cancel' name to...

I have concerns with allowing you to "open" a popover with CSS. You can already force it to display block but that doesn't toggle the aria expanded state for example....

They have distinct aria roles and that's one reason why both proposals use DOM rather than pure CSS to differentiate them. I agree it's important to explain the differences though.

More granular but same overall theme to https://github.com/openui/open-ui/issues/758

https://docs.google.com/document/d/13_Dxxszw2j8ELYUi2FAKPkeUZ1ddcKUnX_ZRGqPErXs/edit - Google doc to discuss this stuff further to come up with a good explainer @gregwhitworth (just copying from previous PR so it doesn't get lost)

That makes sense, when I'm back I'll clean this up and get it ready to land an initial explainer, and then once we get stuff like the browser anatomies merged...

Alternatively I reckon at least call it combobox not selectlist. While they're similar they are distinct components.