Luke Warlow

Results 596 comments of Luke Warlow
trafficstars

Made a demo page with a "polyfill" https://demo.lukewarlow.dev/lightdismiss/

I would want to avoid click in the name because it ties it to a specific input type. I also would want to avoid closeon because it's too similar to...

closers is quite nice and short.

Am I correct in thinking that escape doesn't actually close a non-modal (non-popover) dialog currently. Is that gonna impact on the serialising of the default?

Should closetrigger allow you to control popovers too? Manual popovers require JS currently but that might be heavy handed if you just wanted close request but not click outside? Don't...

This feels like a big win for developers and having looked at the changes I don't think it's likely to cause any issues. Especially because it's unlikely developers will be...

Does the same issue apply to inputs? The idea with the spec is to match inputs existing behaviour.

Other than back compat I can't think of a reason not to

I can't find a way to unresolve the comment and it's not relevant to this PR anymore since it's been removed, but if Chrome is using HTMLString as a return...