Luis Herranz

Results 125 comments of Luis Herranz

Ok, I understand. The `_amp` query is probably not a good idea then. Still, having to enable the `website experience` to get a field in the REST API doesn't look...

It's obviously your take guys, but I still think that if you want REST API support without affecting your site, having to enable `website` and disable all the templates is...

The first things I need help with: - Does the `AMP_REST_API` class have the correct name? - Is the `AMP_REST_API` in the correct place? - How can I load the...

For some reason Travis is saying this: ``` FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | There must be no blank lines before the file comment |...

> @luisherranz Please see my comments/questions here: #2827 (comment) Oh yes, I was writing my answer to that discussion, sorry it took me a while ☺️

> To fix the error, remove the blank line manually. I see. Thanks @swissspidy :)

> [ ] Prevent serving AMP in post entity response if AMP is disabled for the post. @westonruter, @swissspidy: what API should I use to determine if AMP is disabled...

> Build failure on WordPress trunk is unrelated, see #2891. Ok. I've subscribed to the issue to rebase or merge the fix once is done.