Luis Herranz

Results 125 comments of Luis Herranz

It just does it, it's not about the extensions.

Is it safe to do this to get both `push` and `routerDidChange` working with `redux-saga`? ``` javascript const store = compose( reduxReactRouter({createHistory: createBrowserHistory}), applyMiddleware.apply(null, [createSagaMiddleware()]), reduxReactRouter({createHistory: createBrowserHistory}), devTools() )(createStore)(transducers(reducers), initialState)...

I've just noticed the same thing. This is my reproduction: https://stackblitz.com/edit/vitejs-vite-csqbr6?file=src%2FApp.jsx --- EDIT: I confirm that switching to `jsxRuntime: 'classic'` fixes the issue. ```js export default defineConfig({ plugins: [ react({...

Did you try asking on stackoverflow?

Any news on this?

Yep, it has stopped working in Deezer.

I've done a PR to fix it: https://github.com/feedbee/keysocket/pull/14

@solkimicreb what is your plan to add batching between `await`s? Use the `Set` handler to start the batching? If it's not, may I know why did you ditch that idea...

Gotcha. Thanks for the explanation @solkimicreb. I think doing async flushing on React is fine, and as you say, it's going to be the default once they release the Concurrent...

I've been thinking a bit more about this in the last weeks and I am starting to think that moving to async batching may not be the best idea after...