Luis Pineda

Results 63 comments of Luis Pineda

Yes, that's a good observation. I also agree that `VariableDifference` (and maybe `Between`?) should move up to core folder. @mhmukadam and I were also discussing renaming this function (see #174),...

Hi @akashsharma02, thanks a lot for your interest and kind words! My first suggestion was going to be to try implicit or truncated modes, but it looks like you have...

Hi @Rohan138, took a quick high-level glance and so far it looks good. I will start looking at the code in `algorithms/dreamer` and the `DreamerAgent` more closely now. I noticed...

@Rohan138 trying to pull from your fork as shown below, but I run into access permission errors. Could you see if I can get read access? ```bash git checkout -b...

> git checkout -t Rohan138/dreamer I tried a couple of things and I got errors: ![image](https://user-images.githubusercontent.com/4759586/173131152-cf9011d3-0978-4194-96e2-c3e35a1c3ab6.png) ![image](https://user-images.githubusercontent.com/4759586/173131193-0f1c7891-81c2-4ad2-a7da-051a89413461.png)

HTTP worked for me before accepting the invitation, thanks!

> On the non-Dreamer fixes: > > * I renamed `pyproyect.toml` to `pyproject.toml` > * I removed the lines pinning `python==3.7` on all commits > * There's no black version...

@Rohan138 planning to spend most of today and then Friday playing around with your code. Is there anything in particular you'd like for me to focus on or help with?...

Hey, curious to know why.

I'm still using Hydra composition, but maybe the name overrides is misleading? The reason for this config group (overrides) is that I can give users default hyperparameter values that work...