theseus icon indicating copy to clipboard operation
theseus copied to clipboard

`th.eb` is never introduced in tutorial

Open ddetone opened this issue 2 years ago • 1 comments

❓ Questions and Help

I am going through the tutorial an noticed that th.eb is never introduced. Looking at the code it seems that eb stands for embodied? That seems odd that a core cost function is under than namespace

image

https://github.com/facebookresearch/theseus/blob/main/tutorials/00_introduction.ipynb

ddetone avatar Apr 25 '22 15:04 ddetone

Yes, that's a good observation. I also agree that VariableDifference (and maybe Between?) should move up to core folder. @mhmukadam and I were also discussing renaming this function (see #174), so we could do these two changes together.

luisenp avatar Apr 25 '22 16:04 luisenp