Lucian Smith

Results 113 comments of Lucian Smith

Heh, nope. The getComponentValues(NULL) crashes at startup. ``` test_antimony.exe!std::_Tree::_Find_lower_bound(const libsbml::Model * const & _Keyval) Line 1597 C++ test_antimony.exe!std::map::_Try_emplace(const libsbml::Model * const & _Keyval) Line 175 C++ test_antimony.exe!std::map::operator[](const libsbml::Model * const...

Done! And same phenotype as without the call; crash at: ``` > test_antimony.exe!std::_Tree_val::_Orphan_ptr(std::_Tree_node * const _Ptr) Line 718 C++ test_antimony.exe!std::_Tree::clear() Line 1342 C++ test_antimony.exe!libsbml::SBMLTransforms::clearComponentValues(const libsbml::Model * m) Line 558 C++...

I *think* it would allow the 'empty' hack, but not actually solve the problem, if the 'empty' hack stopped working in the future? As it is, for Antimony in particular,...

The other platform azure builds had no problems at all. It was only Windows/Debug that had the problem. Thanks for letting me know WITH_CHECK still existed! I guess it's no...

Nope! My antimony test program still crashes on SBMLTransforms::clearComponentValues(); I just deleted that line in my branch, and have been using that.

Frank's ``` if (mModelValues.empty()) return; ``` trick does seem to work in my case, but it wouldn't work if I ever used mModelValues, and I'm suspicious of it anyway; I...

The main use case I can think of is for simulators that don't know about speciesReference IDs. When they're constant, you could expunge them from the model, much like initial...

I am obviously not an expert in your system, but would it be possible to introduce an 'Xref' parameter into your parameter list, and relax your dictionary to have a...

(I should add that without something like this, you'll not be able to translate models with variable stoichiometries to SBML.jl Which might be fine if that's out of your scope....

In that case, the issue becomes how COBREXA.jl or SBMLToolkit.jl deal with named and/or changing stoichiometries (or if they simply don't). I would be surprised if constraint-based models have yet...