Lucas Carvalho
Lucas Carvalho
First version finished. Reviewers: @msbrogli @pedroferreira1
Thanks for the comments @msbrogli. Here are the answers: > Why would we emit these events? Haven't they been emitted before? I feel the most natural behavior would be to...
> I also had the same impression that --skip-load-events may not be a good flag. I was going to suggest reversing it to --emit-load-events, but maybe there's a better alternative....
> Is this possible to do? If so, how? > > Maybe this should be considered in the design as well. Currently to create snapshots we simply zip the whole...
> I think that makes sense, finding these specific events seems relevant, so we don't have to make a O(n) scan for example. I think that a consideration for that...
Thanks for the comments @msbrogli. Here is the answer to your points: > Problem: Another problem happens when the websocket gets disconnected for any reason. In this case, events might...
@pedroferreira1 comments: > I feel we should have a maximum value here for the size, otherwise the user might request a number of events that could DoS the node. I...
@msbrogli : > I feel we should have a low level design as well. I guess the POC might help you to do it. As far as I understood, you...