Loren Segal

Results 145 comments of Loren Segal

This is probably due to Roby's use of plugins with YARD local builds: https://github.com/rock-core/tools-roby/blob/master/lib/roby/yard.rb Custom plugins are supported during build phase but not for templating (unless whitelisted), so it's possible...

@thomthom I actually like this as a solution that uses jquery-migrate to handle the deprecated APIs. Did you verify that all pages load correctly with this version?

It's possible that this was fixed by #1389, in which case this will be available in the next release. You can check by pulling that branch or testing from the...

> It's clear that YARD's approach of using the lexer events to determine "how far" it has reached in a source file, and how much of the textual source code...

I'm not a fan of bringing in unnecessary required dependencies, and it looks like `parser` is pure-Ruby, which I imagine will bring _significant_ performance costs to parsing. Both of those...

I guess I don't really agree with where effort and complexity is being placed on solving this problem. It seems like there are simpler ways to solve this in a...

> What I am referring to as "extraneous nodes" are things like void_stmt nodes, which you can completely strip out of the AST without breaking anything in YARD. Or the...

> Would you be opposed to moving that method into YARD::Parser::Ruby::ParameterNode and deprecating the current method? Generally speaking, yes, since the AST is not responsible for (re-)formatting its own nodes...

Do you mind opening this as a pull request (with just the fix / tests)? That would be easier to review and merge.

@MSP-Greg RipperParser is an internal class so it doesn't have its own test file IIRC. Anything but the MethodObject would be appropriate, the closer to the code the better, but...