Leo Singer

Results 58 comments of Leo Singer

@mylesboone, would you comment inline in this PR to indicate what changes are necessary?

@mylesboone, do you know how to comment on lines of code in a PR? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-comments-to-a-pull-request

> @lpsinger I'm not sure if your comment was made sincerely or not. I'll give you the benefit of doubt and assume it was made sincerely. Yes, I do know...

We've been using this in production for several months now in https://github.com/nasa-gcn/gcn.nasa.gov/blob/main/app/email-incoming/support/index.ts.

@pcattori, I think that part of the problem is that arc sandbox itself doesn't handle signals. I opened the PR https://github.com/architect/sandbox/pull/729 to try to address that. Would you please see...

I didn't add any documentation for this because I could not find the file for https://remix.run/docs/en/v1/hooks/use-route-loader-data on the dev branch.

> This change needs to target the `dev` branch. Also make sure you don't include other commits than yours in the PR Fixed.

It's been a bit over a month now since the last correspondence on this PR. Any updates?

Thanks for the clarification. See https://github.com/conda-forge/python-confluent-kafka-feedstock/pull/86