pczarnecki

Results 16 comments of pczarnecki

@gmarull thank you for your review. I've already addressed most of the comments. After positive review I will squash fixes with initial set of commits from this PR.

Hi @gmarull, I addressed all of your review comments. Please have a look at my changes and let me know if we can treat discussions in this PR as solved.

Starting from yesterday (13.10.2022) I'd see rather strange failure here in CI, e.g.: https://github.com/zephyrproject-rtos/zephyr/actions/runs/3248323211/jobs/5329395390 It seems like it is unrelated to the PR (failure on board `mps3_an547`): ``` INFO: Error...

Hi @gmarull, please have a look at this PR once again. I addressed all of your comments and thanks to https://github.com/zephyrproject-rtos/zephyr/pull/51336 we've got working CI.

Hi @gmarull, sorry for pinging you again but this PR is ready for your review. Could you please take a look at it?

Responded to all remaining comments and fixed `UART_INTERRUPT_DRIVEN` Kconfig selection. Please let me know if there is anything else to address here.

> @lpawelcz can you add some markdown documentation on how to test the implementation against `decorecorpus`? (even if that just reference the blaze rules to run) > Would it make...

Sure, we are working on a CI workflow similar to the one in https://github.com/google/xls/pull/1215

Sorted out the issue with `peripheral-id` property, current solution should work on all SiLabs platforms. @gmarull please take a look into changes in https://github.com/zephyrproject-rtos/zephyr/pull/50352/commits/3d63b75d533255080b146324df8f373bbed80a38 and https://github.com/zephyrproject-rtos/zephyr/pull/50352/commits/d13c92408dc1e37cbbd36c8b75585b83388b7ee5 and let me know...

It seems like [failures](https://github.com/zephyrproject-rtos/zephyr/pull/50352/checks?check_run_id=9478691624) in CI are unrelated to my changes and are caused by warnings from building `tests/drivers/counter/counter_basic_api` on STM platforms: * stm32f103_mini * nucleo_l4a6zg * nucleo_f103rb Created https://github.com/zephyrproject-rtos/zephyr/issues/52235...