zephyr icon indicating copy to clipboard operation
zephyr copied to clipboard

Initial support for EFR32BG22

Open lpawelcz opened this issue 2 years ago • 3 comments

This PR supersedes PR #35361 and is a minimal version thereof. Its main purpose is to introduce basic support for the BRD4184B board using the EFR32BG22 SoC.

The PR consists of:

  • Pinctrl driver
  • Modifications to the UART driver
  • Sleep Timer (Real-Time Counter) driver and tests support
  • EFR32BG22 SoC support
  • EFR32BG22-SLTB010A board support

Initial support was verified on hardware by running the following samples:

  • hello_world
  • blinky
  • counter/alarm
  • subsys/shell/shell_module

This PR should be merged only after https://github.com/zephyrproject-rtos/hal_silabs/pull/19 is merged and hal_silabs revision in west.yml is bumped to the newest one.

lpawelcz avatar Sep 19 '22 09:09 lpawelcz

@sateeshkotapati ping FYI

str4t0m avatar Sep 19 '22 10:09 str4t0m

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs https://github.com/zephyrproject-rtos/hal_silabs/commit/1ec8dd99aa4ac3e8632d2aa28a7438049bb27102 https://github.com/zephyrproject-rtos/hal_silabs/commit/9dcaa761258cfdfecaacc5a9f0af92f6535d74a3 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

zephyrbot avatar Sep 19 '22 11:09 zephyrbot

@gmarull thank you for your review. I've already addressed most of the comments. After positive review I will squash fixes with initial set of commits from this PR.

lpawelcz avatar Sep 21 '22 11:09 lpawelcz

Hi @gmarull, I addressed all of your review comments. Please have a look at my changes and let me know if we can treat discussions in this PR as solved.

lpawelcz avatar Oct 10 '22 09:10 lpawelcz

Starting from yesterday (13.10.2022) I'd see rather strange failure here in CI, e.g.: https://github.com/zephyrproject-rtos/zephyr/actions/runs/3248323211/jobs/5329395390 It seems like it is unrelated to the PR (failure on board mps3_an547):

INFO: Error found: tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cq31.fpu on mps3_an547 (Not enough FLASH but is one of the integration platforms)

It also happens in other PRs: https://github.com/zephyrproject-rtos/zephyr/actions/runs/3247296293/jobs/5327088678

lpawelcz avatar Oct 14 '22 09:10 lpawelcz

Hi @gmarull, please have a look at this PR once again. I addressed all of your comments and thanks to https://github.com/zephyrproject-rtos/zephyr/pull/51336 we've got working CI.

lpawelcz avatar Oct 18 '22 10:10 lpawelcz

Hi @gmarull, sorry for pinging you again but this PR is ready for your review. Could you please take a look at it?

lpawelcz avatar Oct 24 '22 08:10 lpawelcz

Responded to all remaining comments and fixed UART_INTERRUPT_DRIVEN Kconfig selection. Please let me know if there is anything else to address here.

lpawelcz avatar Oct 25 '22 13:10 lpawelcz

Sorted out the issue with peripheral-id property, current solution should work on all SiLabs platforms. @gmarull please take a look into changes in https://github.com/zephyrproject-rtos/zephyr/pull/50352/commits/3d63b75d533255080b146324df8f373bbed80a38 and https://github.com/zephyrproject-rtos/zephyr/pull/50352/commits/d13c92408dc1e37cbbd36c8b75585b83388b7ee5 and let me know if this is ok for you.

lpawelcz avatar Nov 08 '22 10:11 lpawelcz

It seems like failures in CI are unrelated to my changes and are caused by warnings from building tests/drivers/counter/counter_basic_api on STM platforms:

  • stm32f103_mini
  • nucleo_l4a6zg
  • nucleo_f103rb

Created https://github.com/zephyrproject-rtos/zephyr/issues/52235 for that.

lpawelcz avatar Nov 15 '22 07:11 lpawelcz

@gmarull really appreciate all the good feedback! CI failures seem to have been fixed now in https://github.com/zephyrproject-rtos/zephyr/pull/52279. I rebased and now all tests have passed. Could you please take another look at this PR and assuming everything looks OK, approve it? This is the first of a series of PRs which we have prepared / are preparing which target Silicon Labs platforms. Having this initial PR in place would allow us to subsequently improve the support with fixes, drivers and other platforms.

lpawelcz avatar Nov 21 '22 10:11 lpawelcz

@gmarull thank you for your comments. I addressed those and rebased the code. I also updated pinctrl bindings and added entry in CODEOWNERS file because compliance checks were failing in CI. Please let me know if those changes are OK.

lpawelcz avatar Nov 24 '22 13:11 lpawelcz

@gmarull, @alexanderwachter I addressed your latest comments. Additionally, I had to add a new header to board directory which is necessary for hfxo oscillator initialization after making changes to HAL PR. Please let me know if changes in this PR look OK for you now.

lpawelcz avatar Dec 01 '22 12:12 lpawelcz

Hi @gmarull, PTAL and let me know if you're OK now with the changes.

fkokosinski avatar Dec 06 '22 08:12 fkokosinski

@alexanderwachter could you PTAL? I had to dismiss your ACK to address other comments. Thanks!

fkokosinski avatar Dec 06 '22 09:12 fkokosinski

Hi @gmarull, @cfriedt and @alexanderwachter. I had to rebase this PR due to a conflict in samples/drivers/counter/alarm/src/main.c. PTAL at this PR. Thanks!

fkokosinski avatar Dec 13 '22 09:12 fkokosinski

Hi @gmarull, @cfriedt and @alexanderwachter. I had to rebase this PR due to a conflict in samples/drivers/counter/alarm/src/main.c. PTAL at this PR. Thanks!

please merge HAL PR and update sha as well.

gmarull avatar Dec 13 '22 10:12 gmarull

https://github.com/zephyrproject-rtos/hal_silabs/pull/19 has been merged.

stephanosio avatar Dec 20 '22 10:12 stephanosio

Hi @gmarull, @cfriedt, @alexanderwachter. HAL PR has been merged. I rebased the PR and updated HAL sha in west.yml. Please take another look at this PR. Thank you!

lpawelcz avatar Dec 20 '22 10:12 lpawelcz

@lpawelcz This seems to have broken multiple networking tests: https://github.com/zephyrproject-rtos/zephyr/pull/52852/checks?check_run_id=10231260430. Can you provide a fix?

stephanosio avatar Dec 21 '22 13:12 stephanosio

@stephanosio I'll take a look if nobody else is working on it atm

cfriedt avatar Dec 21 '22 13:12 cfriedt

@stephanosio @cfriedt I have the fix already. Give me a second and I will open a PR

lpawelcz avatar Dec 21 '22 14:12 lpawelcz