Lachlan Donald

Results 321 comments of Lachlan Donald

Hmmmm 🤔My initial instinct is to try and solve this with either multi-stage docker builds or the `cache_from` directive. Is the base_service purely there as a hack to provide a...

What if we added `cache_from` support for `run`, so it was: ``` steps: - name: ':docker: :package:' plugins: 'docker-compose#v2.0.0': build: base_service image-repository: ... - wait - name: 'task 1' command:...

Possibly, I guess that `command` sounds a lot like Docker's `CMD`. I reckon if we did this we'd really limit what was exposed to the script, but yeah, it would...

This has come up again, would be a nice way of calling custom run params that haven't been implemented yet. How about `run-script`, which would be a script called instead...

@toolmantim discussion in https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/issues/155 around whether we should do interpolation on `$BLAH` passed into various plugin arguments made me want a way to customize the run command.

@toolmantim I reckon we'd need a separate one for `build-script` / `build-command-override` vs `run-script` / `run-command-override`. I was thinking we'd set as much docker-compose env as we could so that...

It would be a pretty straightforward thing to add, interested to hear a bit more about the use-case!

Awesome! Is there a WIP somewhere that I can look at?

Did you do any thinking about what format / structure of key you'd expect in secrets manager?

@holmesjr I spent a bit of time today expanding on those gists and wrangled it into https://github.com/buildkite/elastic-ci-stack-secrets-manager-hooks. The env support isn't implemented yet, and I rolled back the "use a...