Lachlan Donald
Lachlan Donald
I think I even prefer the explicit pull step before run: ```yaml env: REGISTRY: "xxx.dkr.ecr.us-east-2.amazonaws.com/my-app" steps: - label: ":docker: Prebuild" plugins: - docker-compose#v3.0.0: - pull: images: - ${REGISTRY}:branch-${BUILDKITE_BRANCH} - ${REGISTRY}:latest...
We get to do away with all the complexity around building meta-data keys, and aliases, in exchange for being explicit about what is happening at a docker level.
> Reckon the “images” key is needed for push and pull? Can they be anything other than images? Pull / push retries, and parameters to the pull or push command.
That said, I think it probably simplifies things a lot to have push/pull just be a flat list.
Completely agree we need better errors around this stuff!
Thanks for the report folks, we haven't seen this before, will try and reproduce. Any idea what docker and docker-compose version y'all are using?
> Otherwise, sounds like a bug to be fixed in the CloudFormation, somehow. Unfortunately it can't 😢 There is no way to vary CloudFormation templates based on the length of...
This is how I approached it in an experiment @sj26: https://github.com/buildkite/elastic-ci-stack-for-aws-ecs/blob/2cf72edd0ba9e40335f58b48320ea94d94e3c464/templates/vpc/template.yaml#L9 https://github.com/buildkite/elastic-ci-stack-for-aws-ecs/blob/2cf72edd0ba9e40335f58b48320ea94d94e3c464/templates/vpc/template.yaml#L56-L66 I've been petitioning AWS for `Fn::Size` for 3+ years 😢
Sounds like the underlying issue is the rebalancing across AZs, correct? @sj26 i believe there was some internal discussion around using a lambda to update that setting on the ALB?...
I think I prefer the approach I took in that linked CFN template once you mix in things like public vs private subnets and NAT Gateway redundancy.