Lachlan Donald

Results 321 comments of Lachlan Donald

@arturopie it's a linting error, I'm working on fixes in #623, nearly there.

We've discussed doing this before. It's certainly something that comes up a fair bit, I regularly forget to pass through env. The hard part is that there is no reliable...

We will likely mirror the `propagate-environment` config from https://github.com/buildkite-plugins/docker-buildkite-plugin#propagate-environment-optional-boolean.

I strongly suspect that this is a race condition with docker's logs and stopped containers. At the minute we don't have any good solutions to this, but will keep looking.

Sorry about this @bjeanes! I've been meaning to apply the same approach we took in https://github.com/buildkite-plugins/docker-buildkite-plugin/pull/68 to this plugin. I believe with that logic, your command would be interpreted to...

See https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/186 for context.

I am increasingly tempted to ditch user namespace remapping.

Currently, the `agent-socket` experiment needs `BUILDKITE_AGENT_ENDPOINT` and `BUILDKITE_AGENT_ACCESS_TOKEN`. I'm considering changing this to leave those env alone and instead add a new env which is `BUILDKITE_AGENT_SOCKET` to more closely follow...

One downside to automatically trying to mount the buildkite-agent binary is that (like mounting the working dir), it falls apart quickly in things like kubernetes.