Louis Wasserman

Results 167 comments of Louis Wasserman

This reads to me like an issue with `callbackFlow`, not with grpc-kotlin -- you're unhappy with how a `callbackFlow` handles closure interrupting a stream of messages. Are you asking for...

This looks like a bug with https://github.com/uber/NullAway.

Google primarily uses the already-available [Android Kotlin style guide](https://developer.android.com/kotlin/style-guide), with only a handful of changes -- mostly that we use a 2-space indent. For formatting, we primarily use [ktfmt](https://github.com/facebookincubator/ktfmt), which...

Copying some internal discussion and thoughts. I was actually writing some Kotlin Truth subjects just as this issue got posted, so I had a couple. I think @cgruber is right...

I have some concerns about making this method *that* discoverable. If it's an extension method, and your IDE always suggests it, then `assert` will come up in the autocomplete of...

I don't think we have it in the external version, but our internal version has an FAQ entry: ### Why can't I use magic comments to disable formatting for certain...

Usually, I find the most convenient idiom for this ``` suspend fun race(vararg races: suspend () -> R): R { return channelFlow { for (race in races) { launch {...

@jamesward is correct; we do not currently provide any API like this. I think there also may be confusion between `io.grpc.Status` and [`com.google.rpc.Status`](https://googleapis.github.io/googleapis/java/all/latest/apidocs/com/google/rpc/Status.html), the latter of which would just use...

It is specifically intended that we do not have a dependency from gRPC-Kotlin to Kotlin protos, which is why things are the way they are today.

This does look safe to me.