Louis Wasserman comments

Results 167 comments of


                                            Louis Wasserman

Concurrency issue between get(K key, Callable<? extends V> valueLoader) and invalidate(Object key)

Let's assume that we did what you're saying: we invalidated the pending fetch. What exactly should the ongoing get() call from the other thread return? Restarting the load() call seems...

Concurrency issue between get(K key, Callable<? extends V> valueLoader) and invalidate(Object key)

Okay. If I understand correctly, that stale value will never be stored, but will be returned from the get?

Concurrency issue between get(K key, Callable<? extends V> valueLoader) and invalidate(Object key)

I don't think that's 100% obvious -- I suspect there are cases where you don't want the value-in-flight to be invalidated -- and I'd also expect this to require a...

Concurrency issue between get(K key, Callable<? extends V> valueLoader) and invalidate(Object key)

Please do; I think we'd welcome contributions on this.

UnsignedShort patch as pull request

Can you give us more details about what specific UnsignedShorts methods you would personally need? Note that Java 8 added some unsigned type support, so I'm not sure we want...

Guava ImmutableList (and others) offer awful performance in some cases due to size-optmized specializations

We've been addressing this, and most immutable collection types are down to bimorphic now. We'll continue paying attention to this, though.

Randomly getting `io.grpc.StatusException: INTERNAL` on all requests

What is your server written in? Is it also using gRPC-Kotlin? I don't see any way changing your _client_ to gRPC-Kotlin could introduce `INTERNAL` errors.

Client example illustrating request cancelation, etc

How would you expect this to differ from just a part of the existing example? Is the intention just to have something shorter for users who don't need the full...

Provide more flexible HTTP/2 flow control options

To be clear, when you mention disabling HTTP/2 flow control from Java, are you referring to disableAutoInboundFlowControl and the like?

Support for Kotlin native / multiplatform

We would certainly like to do this in the long term, but a unified Kotlin solution for protos that is compatible with the Java API, which is a pretty enormous...