Robert Burke comments

Results 75 comments of


                                            Robert Burke

[Bug]: Mismatch in single-precision float encoding between Java and Go RowCoder implementations

Ah whoops. The problem is that there are two separate parts for Row Coding: actually encoding from the Go structs (which Jacks PR did) and converting those struct types to...

[Bug]: Dataflow worker retries pipeline if FinishBundle blocks for too long

I'll note that that advice is for streaming pipelines, not batch pipelines. The code should still institute a cap to the batch sizes (where it then makes the request, and...

[Bug]: Dataflow worker retries pipeline if FinishBundle blocks for too long

The worst thing would be that the Java SDK has as different "keep alive" behavior than the Go SDK. This should be handled in the FnAPI with the bundle progress...

Improved test coverage and fix the implementation of Inject and CoGBK

Change causes some of the regression tests to fail https://ci-beam.apache.org/job/beam_PreCommit_Go_Commit/12491/console I'm a bit indisposed this week due to a summit at work, but when I get a moment I'll see...

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Postcommit

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Flink ValidatesRunner

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Spark ValidatesRunner

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Samza ValidatesRunner

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Spark ValidatesRunner

Improved test coverage and fix the implementation of Inject and CoGBK

Run Go Flink ValidatesRunner